Android Adblock app,android - Complete AdBlock inside WebView - Stack Overflow

I am about to roll out WebView AdBlocking in my android app. I want to know if this will effectively block ads or if there is more to be done say within the Webview itself which I have not modified. Basically I have a host file of stored in Android assets which lists hundred of ad server sites. I read this file in to my AdBlocker and then apply it inside the WebViewClient as follows:

// AdBlocker.isAdURL(String url)

public Boolean isAdURL(String url){

Boolean retValue = false;

if ((url == null) || (url.isEmpty()))

return false;

if ((adServers == null)|| (adServers.size() <1))

return false;

try{

String domainName = getUrlsDomain(url);

if (adServers.contains(domainName)) {

retValue = true;

}

} catch(URISyntaxException e){

}

return retValue;

}

And I only use this in WebViewClient as follows:

@Deprecated

@Override

public WebResourceResponse shouldInterceptRequest(WebView view, String url) {

if (adBlocker.isAdURL(url)) {

ByteArrayInputStream nada = new ByteArrayInputStream("".getBytes());

return new WebResourceResponse("text/plain", "utf-8", nada);

}

return super.shouldInterceptRequest(view, url);

}

And similarly:

@Override

public WebResourceResponse shouldInterceptRequest(WebView view, WebResourceRequest request) {

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {

if (adBlocker.isAdURL(request.getUrl().toString())) {

ByteArrayInputStream nada = new ByteArrayInputStream("".getBytes());

return new WebResourceResponse("text/plain", "utf-8", nada);

}

}

return super.shouldInterceptRequest(view, request);

}

Anything more need to be done? Or is that it? Any need to keep a whitelist or will this generally work assuming my list of adservers is current?